Applies micro-optimizations and removes obsolete settings #5591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies micro-optimizations that were found to improve element creation benchmarks by 5-10%, and removes obsolete settings: * Removed `legacyNoBatch` and `legacyNotifyOrder` settings. * dom-if/repeat: `dom-change` and `renderedCount` no longer fire with `legacyOptimizations` set. * legacy-element-mixin: `isAttached` now set before calling `connectedCallback` so it is batched with initial rendering. * `PropertiesChanged`: property accessor code now inlined for efficiency rather than calling `_get/_setProperty`. The `__dataCounter` tracking flag has been moved here to avoid the need to override `_flushProperties` in `PropertyEffects`. * `PropertyEffects`: inlined `runEffectsForProperty` into `runEffects` for efficiency. Removed wrapping around sending data events. * `async`: In the microtask scheduler, now only provoke a DOM mutation if needed.
|
Based on in-the-wild code relying on |
- Remove node_modules caching - Regen package-lock just in case
kevinpschaaf
approved these changes
Sep 19, 2019
…redItemCount on that. Matches Polymer 1 setting for better backward compatibility.
This was causing a number of rendering tests to fail. Needs investigation, but possibly because wrapping calls ShadyDOM.flush, and this alters distribution timing which some tests may have inadvertently relied on.
sorvell
commented
Sep 23, 2019
sorvell
commented
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies micro-optimizations that were found to improve element creation benchmarks by 5-10%, and removes obsolete settings:
legacyNoBatchandlegacyNotifyOrdersettings.dom-changeandrenderedCountno longer fire withlegacyOptimizationsset.LegacyElementMixin:isAttachednow set before callingconnectedCallbackso it is batched with initial rendering.PropertiesChanged: property accessor code now inlined for efficiency rather than calling_get/_setProperty. The__dataCountertracking flag has been moved here to avoid the need to override_flushPropertiesinPropertyEffects.PropertyEffects: inlinedrunEffectsForPropertyintorunEffectsfor efficiency. Removed wrapping around sending data events.async: In the microtask scheduler, now only provoke a DOM mutation if needed.