Build computed graph from dependencies, rather than properties. #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpschaaf
requested review from
dfreedm,
sorvell and
TimvdLippe
as code owners
kevinpschaaf
force-pushed
the
legacy-undefined-noBatch-orderedDeps
branch
from
013133c
to
064d0ef
Compare
sorvell
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
orderedComputedalgorithm started at the element'spropertiesto build the DAG of edges used to sort the computed effects. However, this would miss any undeclared dependencies of computed properties, causing those computed properties to fail to be correctly inserted into the final order.This change builds the "ready" list of properties from the keys of the computed effects (properties that kick off computed effects) rather than
properties, which removes the footgun around undeclared dependencies.