Avoid over-warning on templatizer props and "static" dynamicFns. #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpschaaf
requested review from
dfreedm,
sorvell and
TimvdLippe
as code owners
sorvell
suggested changes
Feb 19, 2019
lib/mixins/element-mixin.js
Outdated
| @@ -777,7 +777,9 @@ export const ElementMixin = dedupingMixin(base => { | |||
| // The warning is only enabled in `legacyOptimizations` mode, since | |||
| // we don't want to spam existing users who might have adopted the | |||
| // shorthand when attribute deserialization is not important. | |||
| if (legacyOptimizations && !(prop in this._properties)) { | |||
| if (legacyOptimizations && !(prop in this._properties) && | |||
There was a problem hiding this comment.
Let's add some comments about these special cases.
sorvell
approved these changes
Feb 21, 2019
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #5493