Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type jsdoc to templatize root property. #5458

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Add type jsdoc to templatize root property. #5458

merged 1 commit into from
Dec 14, 2018

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Dec 13, 2018

This allows analyzer to understand it for typings/docs.

@aomarks
Add type jsdoc to templatize root property.
0da022f 
This allows analyzer to understand it for typings/docs.
dfreedm
dfreedm approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@dfreedm dfreedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aomarks aomarks merged commit df6463d into master Dec 14, 2018
@aomarks aomarks deleted the templatize-root branch December 14, 2018 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreedm dfreedm dfreedm approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@sorvell sorvell Awaiting requested review from sorvell

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aomarks @dfreedm @googlebot