Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method to force CE polyfill on. Fixes #5267. #5268

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Fix method to force CE polyfill on. Fixes #5267. #5268

merged 1 commit into from
Jun 25, 2018

Conversation

kevinpschaaf
Copy link
Member

@kevinpschaaf kevinpschaaf commented Jun 22, 2018 •
edited
Loading

Fix method to force CE polyfill on in shady tests.

Reference Issue

Fixes #5267.

@kevinpschaaf kevinpschaaf mentioned this pull request Jun 22, 2018
Merged
TimvdLippe
TimvdLippe approved these changes Jun 22, 2018
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we still have test failures 😢

@dfreedm dfreedm merged commit acc7757 into 2.x Jun 25, 2018
@dfreedm dfreedm deleted the 5267-kschaaf-force-ce branch June 25, 2018 23:30
@TimvdLippe TimvdLippe mentioned this pull request Jun 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

@dfreedm dfreedm dfreedm approved these changes

@sorvell sorvell Awaiting requested review from sorvell

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinpschaaf @dfreedm @TimvdLippe @googlebot