3.x tests #5200
Merged
3.x tests #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
April 17, 2018 10:59
|
related: |
test/unit/shady-unscoped-style.html
Outdated
| assertComputed(el1.$.fromImport, '2px'); | ||
| assertComputed(el2.$.fromStyle, '1px'); | ||
| assertComputed(el2.$.fromImport, '2px'); | ||
| }); |
There was a problem hiding this comment.
Why are all these tests removed? The fromStyle ones seem to just be style module-related...
There was a problem hiding this comment.
The second set are deleted because there is nothing to dedupe since we don't have the css html import
There was a problem hiding this comment.
relevant tests added back in
sorvell
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number of Chrome failing tests 56 -> 17. Remaining are assigned to Dan and we have a plan of action for each assigned to him already. Unfortunately adding
import.meta.urlto some of thedom-moduleassetpaths has caused FF and Safari to completely break until polyserve can sent AMD modules to browsers that implementimportbut notimport.metaFor info on what I fixed and what was wrong, see this doc (visible only to googlers).
CC @azakus
I branched off of
3.x-modularizedwhich is branched off of3.x. Merge target is the modularized one. LMK if you want me to change the merge target.