Allow legacy element property definitions with only a type. Fixes #5173 #5174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaamanen
requested review from
dfreedm,
kevinpschaaf,
sorvell and
TimvdLippe
as code owners
TimvdLippe
approved these changes
Apr 3, 2018
There was a problem hiding this comment.
LGTM. This does bring up a broader question on how we can add a "regression test" to prevent us from regressing in this particular case. We probably need to create a separate test folder with TypeScript files that must compile for the build to succeed. However, this is not an issue for this PR, we should discuss that in a separate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow legacy element properties also be of type
Functionfor shorthand definitions.Reference Issue
Fixes #5173