Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several issues in the documentation of dom-* elements #5129

Merged
merged 2 commits into from
Feb 23, 2018

Conversation

TimvdLippe
Copy link
Contributor

By splitting the javascript from the HTML we can now have proper formatting and highlighting in the custom element example definition in the <dom-repeat> docs. Also add a missing " in <custom-style> docs.

Reference Issue

Fixes #4727

Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kevinpschaaf kevinpschaaf merged commit 0657de0 into master Feb 23, 2018
@TimvdLippe TimvdLippe deleted the dom-element-documentation branch April 9, 2018 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants