Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license links #5103

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Fix license links #5103

merged 1 commit into from
Feb 20, 2018

Conversation

abdonrd
Copy link
Contributor

@abdonrd abdonrd commented Feb 8, 2018

Edit: Oh, the auto request review is nice!

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine to me, but we should investigate where this error was introduced. If for example we have a broken license template somewhere. @azakus do you what the policy here is? (I usually copy-paste from any other random file)

@abdonrd
Copy link
Contributor Author

abdonrd commented Feb 9, 2018

Btw, would be nice to use https instead of http.

I have not changed it because you have http everywhere.

Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinpschaaf kevinpschaaf merged commit 5a044f8 into Polymer:master Feb 20, 2018
@abdonrd abdonrd deleted the fix-license branch February 20, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants