Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude index.html from type generation. #5076

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Exclude index.html from type generation. #5076

merged 1 commit into from
Jan 30, 2018

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Jan 30, 2018

An upcoming change to gen-typescript-declarations will produce d.ts files even for HTML files with no script, so we need to exclude cases like this.

Reference Issue

@aomarks aomarks requested a review from dfreedm January 30, 2018 23:54
@aomarks aomarks merged commit 6fc285c into master Jan 30, 2018
@aomarks aomarks deleted the no-index-types branch January 30, 2018 23:54
@aomarks aomarks mentioned this pull request Jan 31, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreedm dfreedm dfreedm approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@sorvell sorvell Awaiting requested review from sorvell

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aomarks @dfreedm @googlebot