Fix issue with observers being called twice #5068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorvell
suggested changes
Jan 29, 2018
lib/mixins/properties-mixin.html
Outdated
| if (!constructor.hasOwnProperty(JSCompiler_renameProperty('__ownProperties', constructor))) { | ||
| let props = null; | ||
|
|
||
| if (constructor.hasOwnProperty('properties') && constructor.properties) { |
There was a problem hiding this comment.
I imagine we probably need JSCompiler_renameProperty for properties, don't we?
There was a problem hiding this comment.
The weird part is, with or without produces the same output. Nonetheless, I have added the line.
sorvell
approved these changes
Jan 30, 2018
|
Is this the sort of fix that we could get a 2.4.1 release out of? Possibly soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were checking whether the class actually had the property (https://github.com/Polymer/polymer/pull/4840/files#diff-41695d1bc0c64b86f0e5a7878f58df0fL118), however, in the changed version we were not. This change makes sure that if a class does not define a
propertiesgetter, it does not traverse up the prototype chain and retrieve thepropertiesblock from the superClass (thus processing all properties twice).Reference Issue
Fixes #5067