Fix issue where el.splice could not clear full array #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorvell
reviewed
Jan 23, 2018
lib/mixins/property-effects.html
Outdated
| // | ||
| let ret; | ||
| // Omit any additional arguments if they were not passed in | ||
| if (start !== undefined && !deleteCount && !items.length) { |
There was a problem hiding this comment.
For simplicity, let's just check if arguments.length ==2
sorvell
suggested changes
Jan 23, 2018
|
@sorvell I have updated the if-condition. Could you approve this PR? |
kevinpschaaf
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gist of the issue is that, depending on the number of arguments passed on to
array.splice, splice does different things. We were eagerly settingstartto 0 and passing all 3 arguments. Instead, check which case we actually have and fix the case when onlystartis passed in.Reference Issue
Fixes #5032