Fix regression with imported css #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix case where `<link rel="import" type="css">` is the only styling for an element Fixes #4986
TimvdLippe
approved these changes
Dec 12, 2017
lib/mixins/element-mixin.html
Outdated
| let templateStyle = templateStyles[templateStyleIndex]; | ||
| // if no styles in the template, fall back to first element child of template | ||
| let templateStyle = templateStyles.length ? | ||
| templateStyles[templateStyleIndex] : template.content.firstElementChild; |
There was a problem hiding this comment.
Lacking the knowledge, but I assume the firstElementChild represents the style tag represents the .css file?
There was a problem hiding this comment.
This just says put any non-local styles either before the closest local template style or at the top of the template
There was a problem hiding this comment.
No, the <link> element won't make it into the template.
There was a problem hiding this comment.
This will still throw if there's no firstElementChild.
There was a problem hiding this comment.
Yup, good point. Let me make the smallest possible repro.
Always put `<link rel="import" type="css">` styles at the top
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix case where
<link rel="import" type="css">is the only styling foran element
Fixes #4986