Do not set touchend listeners to passive #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`touchend` listeners do not need to be passive to enable more performant scrolling. With this change, most of the tradeoffs with enabling `passiveTouchGestures` disappear, leaving only the inability to control scrolling from `track`, `down`, and `move` gestures. Fixes #4961
dfreedm
added a commit
that referenced
this pull request
Nov 29, 2017
`touchend` listeners do not need to be passive to enable more performant scrolling. With this change, most of the tradeoffs with enabling `passiveTouchGestures` disappear, leaving only the inability to control scrolling from `track`, `down`, and `move` gestures. 1.x port of #4962
kevinpschaaf
requested changes
Nov 30, 2017
lib/utils/gestures.html
Outdated
| @@ -481,7 +481,7 @@ | |||
| gobj[dep] = gd = {_count: 0}; | |||
| } | |||
| if (gd._count === 0) { | |||
| let options = !isMouseEvent(dep) && PASSIVE_TOUCH(); | |||
| let options = !isMouseEvent(dep) && dep !== 'touchend' && PASSIVE_TOUCH(); | |||
There was a problem hiding this comment.
Move isMouseEvent and touchend check into PASSIVE_TOUCH()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
touchendlisteners do not need to be passive to enable more performantscrolling.
With this change, most of the tradeoffs with enabling
passiveTouchGesturesdisappear, leaving only the inability to controlscrolling from
track,down, andmovegestures.Fixes #4961