[1.x] Adds support for shady-unscoped attribute to style elements.
#4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2017 11:58
These features have been removed from the only native implementation of Shadow DOM v0 (Chrome).
Since `/deep/` has been removed from Shady DOM v0, users must share styles between elements via style modules (e.g. `<style include="shared-style">`). Under ShadyDOM, these styles are scoped and duplicated between elements. If these styles are intended to replace global styling done with `html /deep/ ...` this is inefficient since the styles are needlessly copied to each element style. Therefore, this adds support for a `shady-unscoped` attribute. If this attribute is placed on a style and native Shadow DOM is not in use, then the style is copied once to the document and are left unscoped. Please note, css custom properties are not supported in `shady-unscoped` styles.
dfreedm
requested changes
Oct 19, 2017
| @@ -0,0 +1,26 @@ | |||
| <dom-module id="global-shared1"> | |||
| @@ -0,0 +1,121 @@ | |||
| <!doctype html> | |||
| @@ -0,0 +1,3 @@ | |||
| .import { | |||
dfreedm
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for styles with a
shady-unscopedattributeSince
/deep/has been removed from Shady DOM v0, users must share styles between elements via style modules (e.g.<style include="shared-style">).Under ShadyDOM, these styles are scoped and duplicated between elements. If these styles are intended to replace global styling done with
html /deep/ ...this is inefficient since the styles are needlessly copied to each element style.Therefore, this adds support for a
shady-unscopedattribute. If this attribute is placed on a style and native Shadow DOM is not in use, then the style is copied once to the document and are left unscoped.Please note, css custom properties are not supported in
shady-unscopedstyles.Fixes #4856