Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude script and style tags for parsing bindings #4841

Merged
merged 3 commits into from
Sep 21, 2017
Merged

Exclude script and style tags for parsing bindings #4841

merged 3 commits into from
Sep 21, 2017

Conversation

TimvdLippe
Copy link
Contributor

Previously both <script> and <style> were scanned for bindings. This has unintended side-effects for functions and styles.

Reference Issue

Fixes #3726
Supersedes #3872

@TimvdLippe TimvdLippe requested a review from sorvell September 15, 2017 23:34
@TimvdLippe TimvdLippe mentioned this pull request Sep 15, 2017
Closed
@TimvdLippe
Copy link
Contributor Author

@sorvell @azakus all right tests are now passing 😄

@sorvell sorvell merged commit 6af12ac into master Sep 21, 2017
@sorvell sorvell deleted the exclude-style-script-bindings branch September 21, 2017 23:57
@pineapplemachine pineapplemachine mentioned this pull request Oct 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorvell sorvell sorvell approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimvdLippe @sorvell @googlebot