Update custom-style API doc #4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Polymer/old-docs-site#2266. I didn't test this through the docs generation. Handle with care.
ghost
suggested changes
Jul 25, 2017
lib/elements/custom-style.html
Outdated
| * - Custom properties used by Polymer's shim for cross-scope styling may | ||
| * be defined in an custom-style. Use the :root selector to define custom | ||
| * properties that apply to all custom elements. | ||
| * - Custom properties can be defined in an custom-style. Use the `html` selector |
There was a problem hiding this comment.
Custom properties can be defined in an custom-style.
Should be
Custom properties can be defined in a custom-style.
Also.. sometimes it is custom-style and other times <custom-style>. I am sure there is a reason, just wondering what it is :)
lib/elements/custom-style.html
Outdated
| * - Custom properties can be defined in an custom-style. Use the `html` selector | ||
| * to define custom properties that apply to all custom elements. | ||
| * - Custom mixins can be defined in a custom-style, if you import the optional | ||
| * [apply shim](https://github.com/webcomponents/shadycss#about-applyshim)(`shadycss/apply-shim.html`). |
There was a problem hiding this comment.
|
Tested by following this process: https://www.polymer-project.org/2.0/docs/tools/documentation#create-page Looks mostly great |
|
Thanks for the fixes @katejeffreys—also for cluing me in that I could just review the changes using |
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Polymer/old-docs-site#2266.
I didn't test this through the docs generation. Handle with care.
Reference Issue