Add explicit imports across files inside of polymer #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredKSchott
changed the title
lib/utils/style-gather.html
Outdated
| @@ -8,6 +8,7 @@ | |||
| subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt | |||
| --> | |||
| <link rel="import" href="resolve-url.html"> | |||
| <link rel="import" href="../elements/dom-module.html"> | |||
There was a problem hiding this comment.
This file shouldn't have an import of dom-module. The check below is to see if it's loaded and use it if so, but there are some uses of style-gather that don't necessitate loading dom-module, like custom-style.
There was a problem hiding this comment.
Agreed, removing
|
@justinfagnani @sorvell PTAL, PR is now a single line |
|
LGTM from my end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back missing imports. These explicit references are needed for some automated tooling.
/cc @justinfagnani