Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate ESLint 'semi' rule #4651

Closed
wants to merge 2 commits into from
Closed

Activate ESLint 'semi' rule #4651

wants to merge 2 commits into from

Conversation

fredj
Copy link
Contributor

@fredj fredj commented Jun 1, 2017

@TimvdLippe TimvdLippe mentioned this pull request Aug 9, 2017
Closed
@dfreedm dfreedm self-requested a review August 9, 2017 21:10
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 9, 2017
@dfreedm dfreedm added cla: yes and removed cla: no labels Aug 9, 2017
@dfreedm
Copy link
Member

dfreedm commented Aug 9, 2017

@googlebot, that was my commit, silly bot!

@TimvdLippe
Copy link
Contributor

@azakus You missed two 😂 https://travis-ci.org/Polymer/polymer/builds/262839592#L679-L686

@TimvdLippe
Copy link
Contributor

I manually applied the changes in 75c6fff to not miss any changes after merging the other PRs. Thanks for your PR!

@fredj fredj deleted the eslint_semi branch August 17, 2017 06:33
AlphaWong pushed a commit to AlphaWong/polymer that referenced this pull request Aug 21, 2017
@TimvdLippe @AlphaWong
Enable ESLint 'semi' rule
dd3c98a 
Closes Polymer#4651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreedm dfreedm dfreedm approved these changes

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fredj @googlebot @dfreedm @TimvdLippe