Skip to content

Data notifications do not flush host if host has not initialized clients #4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2017
Merged

Data notifications do not flush host if host has not initialized clients #4586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b6981d
Fixes #4585. Data notifications do not flush host if host has not ini…
May 5, 2017
6f1dde7
Fix comment.
May 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/mixins/element-mixin.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,10 +669,14 @@
* @override
*/
_readyClients() {
super._readyClients();
if (this._template) {
this.root = this._attachDom(this.root);
}
// The super._readyClients here sets the clients initialized flag.
// We must wait to do this until after client dom is created/attached
// so that this flag can be checked to prevent notifications fired
// during this process from being handled before clients are ready.
super._readyClients();
}


Expand Down
10 changes: 9 additions & 1 deletion lib/mixins/property-effects.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,11 @@
}
}
// Flush host if we actually notified and host was batching
// And the host has already initialized clients; this prevents
// an issue with a host observing data changes before clients are ready.
let host;
if (notified && (host = inst.__dataHost) && host._flushProperties) {
if (notified && (host = inst.__dataHost) && host._flushProperties
&& host.__dataClientsInitialized) {
host._flushProperties();
}
}
Expand Down Expand Up @@ -1509,6 +1512,11 @@
if (!this.__dataClientsInitialized) {
this._readyClients();
}
// Before ready, client notifications do not trigger _flushProperties.
// Therefore a flush is necessary here if data has been set.
if (this.__dataPending) {
this._flushProperties();
}
}

/**
Expand Down
25 changes: 23 additions & 2 deletions test/unit/property-effects-elements.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@
};
this.titleChanged = sinon.spy();
},
ready: function() {
this.isReady = true;
},
clearObserverCounts: function() {
for (var i in this.observerCounts) {
this.observerCounts[i] = 0;
Expand Down Expand Up @@ -344,7 +347,8 @@
'boundcomputedvalueChanged(boundcomputedvalue)',
'boundcomputednotifyingvalueChanged(boundcomputednotifyingvalue)',
'boundreadonlyvalueChanged(boundreadonlyvalue)',
'boundCustomNotifyingValueChanged(boundCustomNotifyingValue)'
'boundCustomNotifyingValueChanged(boundCustomNotifyingValue)',
'boundnotifyingvalueWithDefaultChanged(boundnotifyingvalueWithDefault)'
],
properties: {
a: {
Expand All @@ -367,7 +371,8 @@
boundcomputedvalueChanged: 0,
boundcomputednotifyingvalueChanged: 0,
boundreadonlyvalueChanged: 0,
boundCustomNotifyingValueChanged: 0
boundCustomNotifyingValueChanged: 0,
boundnotifyingvalueWithDefault: 0
};
},
computeComputedValue: function(a, b) {
Expand All @@ -378,23 +383,39 @@
this.observerCounts[i] = 0;
}
},
assertClientsReady: function() {
assert.isTrue(this.$.basic1.isReady, 'basic1 not `ready` by observer time');
assert.isTrue(this.$.basic2.isReady, 'basic2 element not `ready` by observer time');
assert.isTrue(this.$.basic3.isReady, 'basic3 element not `ready` by observer time');
assert.isTrue(this.$.basic4.isReady, 'basic4 element not `ready` by observer time');
},
boundvalueChanged: function() {
this.assertClientsReady();
this.observerCounts.boundvalueChanged++;
},
boundnotifyingvalueChanged: function() {
this.assertClientsReady();
this.observerCounts.boundnotifyingvalueChanged++;
},
boundcomputedvalueChanged: function() {
this.assertClientsReady();
this.observerCounts.boundcomputedvalueChanged++;
},
boundcomputednotifyingvalueChanged: function() {
this.assertClientsReady();
this.observerCounts.boundcomputednotifyingvalueChanged++;
},
boundreadonlyvalueChanged: function() {
this.assertClientsReady();
this.observerCounts.boundreadonlyvalueChanged++;
},
boundCustomNotifyingValueChanged: function() {
this.assertClientsReady();
this.observerCounts.boundCustomNotifyingValueChanged++;
},
boundnotifyingvalueWithDefaultChanged: function() {
this.assertClientsReady();
this.observerCounts.boundnotifyingvalueWithDefault++;
}
});
</script>
Expand Down