-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support property observers which are direct function references #4574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This SFTM. Could you resolve the merge conflicts and then @kevinpschaaf can probably take a look?
…dition to strings. Provides better static analysis and refactoring support in multiple tools. Alleviates the need for property reflection with Closure-compiler renaming.
99e6bda
to
4bae2b6
Compare
Sorry for the delay. Rebased to tip of tree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked about this PR with @kevinpschaaf In general we feel this is a small quality of life improvement by using the language semantics. We were initially reluctant, as this PR introduce a new way for the same thing. However, as the benefits are substantial and for this case it is small, we are okay with the change.
We need to update the docs for this change as well @arthurevans
Filed Polymer/old-docs-site#2421 to add documentation. |
Oops, ignore me, missed that there already was an issue. |
Partially addresses #4543
Provides better static analysis and refactoring support in multiple tools. Alleviates the need for property reflection with Closure-compiler renaming.
The test case included isn't actually that useful (but does test the change). Real benefits come with the class style syntax: