Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsdoc new tags #4568

Merged
merged 3 commits into from
Jun 20, 2017
Merged

Jsdoc new tags #4568

merged 3 commits into from
Jun 20, 2017

Conversation

justinfagnani
Copy link
Contributor

Don't merge, still checking things out

@dfreedm dfreedm self-requested a review April 28, 2017 17:30
@dfreedm dfreedm self-assigned this Apr 28, 2017
@stramel
Copy link

stramel commented May 18, 2017

/sub Super curious to know what the decided upon...

@dfreedm dfreedm changed the base branch from master to closure-warnings June 20, 2017 19:52
@dfreedm dfreedm changed the base branch from closure-warnings to master June 20, 2017 19:52
Copy link
Member

@dfreedm dfreedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets just merge

@dfreedm dfreedm merged commit 48fdac7 into master Jun 20, 2017
@dfreedm dfreedm deleted the jsdoc-new-tags branch June 20, 2017 19:53
@aomarks
Copy link
Member

aomarks commented Jun 23, 2017

Running the latest Analyzer against this drops a lot of data and breaks the docs site, I guess we need to make some fixes to Analyzer too?

@justinfagnani
Copy link
Contributor Author

Uh oh... Maybe, maybe this PR missed things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants