Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0 Improvements to binding API #4510

Merged
merged 18 commits into from
Apr 13, 2017
Merged

2.0 Improvements to binding API #4510

merged 18 commits into from
Apr 13, 2017

Commits on Apr 7, 2017

  1. Improvements to binding API: 

    - Adds override points for _parseBindings and _evaluateBinding
- Adds support for runtime template binding
- Moves ready(), _hasAccessor tracking, and instance property swizzle at ready time to PropertyAccessors
    @kevinpschaaf
    kevinpschaaf committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    ea4e7d9 View commit details
    Browse the repository at this point in the history

  2. Fix _hasAccessor for readOnly. Collapse addBinding & addBindingEffects

    @kevinpschaaf
    kevinpschaaf committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    396c102 View commit details
    Browse the repository at this point in the history

  3. Put $ on dom, and assign to element as needed. Eliminate _templateInf… 

    …o reference.
    @kevinpschaaf
    kevinpschaaf committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    03bed19 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2017

  1. Address feedback based on review. 

    * PropertyAccessors must call `_flushProperties` to enable
* Avoid tearing off oldProps (unnecessary)
* Add `addBinding` docs
* Merge notifyListeners into `setupBindings`
* Add comment re: path-bindings not being overridable
* Remove `dom` argument from `_bindTemplate`
* Rename `_stampBoundTemplate` back to `_stampTemplate`
    @kevinpschaaf
    kevinpschaaf committed Apr 8, 2017
    Configuration menu
    Copy the full SHA
    6af84c4 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2017

  1. Add initial runtime stamping tests.

    @kevinpschaaf
    kevinpschaaf committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    eb6ab63 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2017

  1. Added tests for custom parsing, effects, and binding.

    @kevinpschaaf
    kevinpschaaf committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    1cf955b View commit details
    Browse the repository at this point in the history

  2. Add tests for adding/removing runtime property effects.

    @kevinpschaaf
    kevinpschaaf committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    1471106 View commit details
    Browse the repository at this point in the history

  3. Ensure prototype wasn't affected by runtime effects.

    @kevinpschaaf
    kevinpschaaf committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    bf2dbe0 View commit details
    Browse the repository at this point in the history

  4. Fix lint error.

    @kevinpschaaf
    kevinpschaaf committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    dff5f2b View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2017

  1. Address feedback from review: 

    * Refactor `_bindTemplate` to remove problematic `hasCreatedAccessors`
* Remove vestigial `dom` from `_bindTemplate` call
* Rename `_unstampTemplate` to `_removeBoundDom`
* Add `infoIndex` to `nodeInfo` (and renamed parent & index)
* Add test to ensure runtime accessors created for new props in runtime stamped template
* Changed custom binding test to use different prop names
* Added test for #first count after removing bound dom
    @kevinpschaaf
    kevinpschaaf committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    b9fafb7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into 2.0-binding-api-refactor

    @kevinpschaaf
    kevinpschaaf committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    cd321a3 View commit details
    Browse the repository at this point in the history

  3. Add more HTMLImports.whenReady

    @kevinpschaaf
    kevinpschaaf committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    bc71318 View commit details
    Browse the repository at this point in the history

  4. use chrome beta

    @dfreedm
    dfreedm committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    0724f18 View commit details
    Browse the repository at this point in the history

  5. alias another way

    @dfreedm
    dfreedm committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    d297047 View commit details
    Browse the repository at this point in the history

  6. [ci skip] Fix comment.

    @kevinpschaaf
    kevinpschaaf committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    becd1d3 View commit details
    Browse the repository at this point in the history

  7. Add more comments

    @kevinpschaaf
    kevinpschaaf committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    d0bd96d View commit details
    Browse the repository at this point in the history

  8. Fix perf regressions.

    @kevinpschaaf
    kevinpschaaf committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    86e35e3 View commit details
    Browse the repository at this point in the history

  9. Eliminate rest args for better perf on stable chrome.

    @kevinpschaaf
    kevinpschaaf committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    fa67457 View commit details
    Browse the repository at this point in the history