Introducing an insertBefore method on Templatize instances
#4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstances. This api should be used to insert instances into the dom.
kevinpschaaf
requested changes
Apr 4, 2017
lib/elements/dom-repeat.html
Outdated
| @@ -580,7 +580,7 @@ | |||
| } | |||
| let beforeRow = this.__instances[instIdx + 1]; | |||
| let beforeNode = beforeRow ? beforeRow.children[0] : this; | |||
| this.parentNode.insertBefore(inst.root, beforeNode); | |||
| inst.insertBefore(this.parentNode, this); | |||
There was a problem hiding this comment.
Should be inst.insertBefore(this.parentNode, beforeNode); (which will also solve your eslint error!!)
added 2 commits
April 4, 2017 10:58
…ore`). Templatize instances now more efficiently propagate changes to clients.
|
Closing this PR since a better fix for the behavior that does not introduce new API is in the works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4447. This api should be used to insert instances into the dom. Using it ensures that sub elements are "readied" before host elements.