Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure _registered is called 1x for each element class using LegacyElementMixin #4438

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Ensure _registered is called 1x for each element class using LegacyElementMixin #4438

merged 1 commit into from
Mar 17, 2017
+32 −13

Conversation

sorvell
Copy link
Contributor

@sorvell sorvell commented Mar 16, 2017

Fixes #4437 . Ensure _registered is called 1x for each element class using LegacyElementMixin. Ensure that a behaviors’s registered method is called for any extending class.

Fixes #4437. Ensure _registered is called 1x for each element class…
de09d73 
… using `LegacyElementMixin`. Ensure that a behaviors’s `registered` method is called for any extending class.
kevinpschaaf
kevinpschaaf approved these changes Mar 17, 2017
View reviewed changes
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinpschaaf kevinpschaaf merged commit 3d054ba into master Mar 17, 2017
@kevinpschaaf kevinpschaaf deleted the fix-4437 branch March 17, 2017 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpschaaf kevinpschaaf kevinpschaaf approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sorvell @kevinpschaaf @googlebot