Separate binding-specific code from template stamp. Expose override points #4432

kevinpschaaf · 2017-03-15T02:54:02Z

No description provided.

…oints.

kevinpschaaf · 2017-03-15T03:13:42Z

lib/mixins/template-stamp.html

+        // since a template may be re-used, memo-ize notes.
+        if (!content._notes) {
+          let notes = content._notes = [];
+          notes.ownerDocument = ownerDocument || template.ownerDocument;


May not be worth threading this through since it's only used for inertness.

kevinpschaaf · 2017-03-15T03:14:54Z

lib/mixins/template-stamp.html

+        return content._notes;
+      }
+
+      // add annotations gleaned from subtree at `node` to `notes`


perhaps (node, note, notes)

kevinpschaaf · 2017-03-15T03:22:18Z

lib/mixins/template-stamp.html

+        let noted;
+        if (node.localName == 'template' &&
+          !node.hasAttribute('preserve-content')) {
+          noted |= this._parseTemplate(node, note);


noted = this._parseTemplate(node, note) || noted

kevinpschaaf · 2017-03-15T03:23:02Z

lib/mixins/template-stamp.html

+          !node.hasAttribute('preserve-content')) {
+          noted |= this._parseTemplate(node, note);
+        } else if (node.localName === 'slot') {
+          node._hasInsertionPoint = true;


add note that this is a Shady DOM optimziation

should be note.notes._hasInsertionPoints = true

kevinpschaaf · 2017-03-15T03:24:50Z

lib/mixins/template-stamp.html

+        if (node.firstChild) {
+          noted |= this._parseTemplateChildNodes(node, note);
+        }
+        if (node.attributes) {


use hasAttributes

kevinpschaaf · 2017-03-15T03:32:09Z

lib/mixins/template-stamp.html

+              if (note.notes.stripWhiteSpace && !node.textContent.trim()) {
+                root.removeChild(node);
+                // decrement index since node is removed
+                i--;


seems like this can just continue and remove the if (node.parentNode) check below

kevinpschaaf · 2017-03-15T03:37:51Z

lib/mixins/template-stamp.html

+      //    children and avoids a bug in Chrome where nested template children
+      //    upgrade)
+      static _parseTemplate(node, note) {
+        let content = node.content.ownerDocument.createDocumentFragment();


remove this and just have 1 inert document?

kevinpschaaf · 2017-03-15T03:39:52Z

lib/mixins/template-stamp.html

+      static _parseTemplateNodeAttributes(node, note) {
+        // Make copy of original attribute list, since the order may change
+        // as attributes are added and removed
+        let attrs = Array.prototype.slice.call(node.attributes);


Array.from

kevinpschaaf · 2017-03-15T03:49:31Z

lib/mixins/property-effects.html

+            name = propertyName;
+          }
+          note.bindings = note.bindings || [];
+          note.bindings.push({


kevinpschaaf · 2017-03-15T04:02:26Z

lib/mixins/property-effects.html

+    // m[1]: '{{'          '[['
+    // m[2]: ''            '!'
+    // m[3]: 'prop'        'compute(foo,bar)'
+    while ((m = bindingRegex.exec(text)) !== null) {


remove !== null

kevinpschaaf · 2017-03-15T04:22:55Z

Consider:

note -> nodeInfo
notes -> templateInfo = { nodes: [ ... ] }
Pass templateInfo through tree walk (and _parseBindings). Hang stripWhitespace, hostProps, dynamicFns, etc. on templateInfo

sorvell · 2017-03-17T03:24:26Z

lib/mixins/template-stamp.html

+      //    (this is both an optimization to avoid re-stamping nested template
+      //    children and avoids a bug in Chrome where nested template children
+      //    upgrade)
+      static _parseTemplateNestedContent(node, outerTemplateInfo, nodeInfo) {


Worth trying to collapse with _parseTemplate? Seems like if there's an outerTemplate, you can do this content stripping.

sorvell · 2017-03-17T03:31:07Z

lib/mixins/template-stamp.html

-  function applyTemplateContent(inst, node, note) {
-    if (note.templateContent) {
-      node._content = note.templateContent;
+  function applyTemplateContent(inst, node, nodeInfo) {


change argument node -> template

Separate binding-specific code from template stamp. Expose override p…

e95afeb

…oints.

googlebot added the cla: yes label Mar 15, 2017

kevinpschaaf commented Mar 15, 2017

View reviewed changes

kevinpschaaf added 5 commits March 17, 2017 12:20

Updates based on PR feedback. API docs in progress.

627352d

nodeInfo -> nodeInfoList

eed6750

Add API docs.

1eb0df4

[ci skip] Update doc

b977480

[ci skip] Update doc

f87790d

sorvell suggested changes Mar 17, 2017

View reviewed changes

sorvell approved these changes Mar 17, 2017

View reviewed changes

sorvell merged commit 6ca0927 into master Apr 4, 2017

sorvell deleted the 2.0-binding-api branch April 4, 2017 00:13

kevinpschaaf mentioned this pull request Apr 7, 2017

2.0 Improvements to binding API #4510

Merged

kevinpschaaf mentioned this pull request Apr 25, 2017

Provide hooks to process custom template annotations #3369

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Separate binding-specific code from template stamp. Expose override points #4432

Separate binding-specific code from template stamp. Expose override points #4432

kevinpschaaf commented Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf Mar 15, 2017

kevinpschaaf commented Mar 15, 2017

sorvell Mar 17, 2017

sorvell Mar 17, 2017

Separate binding-specific code from template stamp. Expose override points #4432

Separate binding-specific code from template stamp. Expose override points #4432

Conversation

kevinpschaaf commented Mar 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevinpschaaf commented Mar 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment