[WIP] dynamic-import importHref() callback fix when the same resource is requested multiple times
#4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gronke
force-pushed
the
extend-tests-dynamic-import
branch
from
92ebfd0 to
977a93a
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
gronke
force-pushed
the
extend-tests-dynamic-import
branch
from
fe43d65 to
3f30a44
Compare
|
CLAs look good, thanks! |
gronke
changed the title
importHref() callback fix when the same resource is requested multiple times
sorvell
suggested changes
Nov 3, 2016
| var imprt = Polymer.Base.importHref(url); | ||
|
|
||
| var onLoad = function() { | ||
| document.removeEventListener('load', onLoad); |
There was a problem hiding this comment.
document here should be imprt
| @@ -0,0 +1,24 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Please remove if this file is not used anywhere.
gronke
referenced
this pull request
in gronke/polymer
Nov 3, 2016
|
@sorvell thanks for the review. all done! |
|
oh this would have also fixed #4124 |
gronke
force-pushed
the
extend-tests-dynamic-import
branch
from
e3e408a to
6cc2451
Compare
gronke
referenced
this pull request
in gronke/polymer
Nov 3, 2016
gronke
force-pushed
the
extend-tests-dynamic-import
branch
from
6cc2451 to
3eb6336
Compare
gronke
referenced
this pull request
in gronke/polymer
Nov 3, 2016
gronke
force-pushed
the
extend-tests-dynamic-import
branch
from
3eb6336 to
9146ec2
Compare
gronke
referenced
this pull request
in gronke/polymer
Nov 3, 2016
gronke
force-pushed
the
extend-tests-dynamic-import
branch
2 times, most recently
from
118fc39 to
a2c4e33
Compare
gronke
changed the title
importHref() callback fix when the same resource is requested multiple timesimportHref() callback fix when the same resource is requested multiple times
addresses Polymer#3814
gronke
force-pushed
the
extend-tests-dynamic-import
branch
from
a2c4e33 to
eade3d2
Compare
gronke
force-pushed
the
extend-tests-dynamic-import
branch
from
247e88a to
1fec33b
Compare
|
Closing in favor of #4209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3814
The expected behavior of
importHref()is that onload or onerror get called once the resource is loaded.When requesting a resource for the second time, we can immediately call the onload or onerror function in case it was already completed. Otherwise we attach to the same events as the previous request.
Unit Test