Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3430 - ie memory leak fixes - disable event caching, fixed resolver u… #3964

Merged
merged 2 commits into from
Dec 5, 2016

Conversation

bbsteventill
Copy link
Contributor

@bbsteventill bbsteventill commented Sep 19, 2016

Reference Issue

…rl adding to root doc, and weak map ie issues

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@bbsteventill
Copy link
Contributor Author

I signed it!

Bloomberg has added me to their cla

[email protected] " data-digest="From: [email protected] " style="">
From: [email protected]
Subject: Re: [Polymer/polymer] 3430 - ie memory leak fixes - disable event caching, fixed resolver u… (#3964)

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
*If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.

*If you signed the CLA as a corporation, please let us know the company's name.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@googlebot
Copy link

CLAs look good, thanks!

…rl adding to root doc, and weak map ie issues
@bbsteventill bbsteventill force-pushed the 3430-ie-memory-leak-fixes branch from 9f84bf0 to a6e66f9 Compare September 27, 2016 15:59
@dtanp
Copy link

dtanp commented Nov 21, 2016

Our team found this problem and this patch helps to solve the problem (partially).

Another issue that causes the leak is HTML Import and we do a workaround by copying components.html to the main page.

Using both solutions together can significantly reduce the leak in IE, even though not totally fixed.

If this patch can be released at earliest, that would be great.

@bbsteventill
Copy link
Contributor Author

FYI webcomponents/webcomponentsjs#644 fixes the memory leaks within web components

@dtanp
Copy link

dtanp commented Nov 22, 2016

thanks @bbsteventill !

@sorvell
Copy link
Contributor

sorvell commented Nov 29, 2016

@azakus can you please review this? Thanks.

@dfreedm dfreedm merged commit a4bda18 into Polymer:master Dec 5, 2016
@jay8t6
Copy link

jay8t6 commented Dec 6, 2016

@azakus @sorvell when is the next release coming out? I'd love to see the performance improvement in IE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants