Ready/attached ordering #3947
Merged
Ready/attached ordering #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
This was referenced Sep 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3933, #3930.
Ensure dom is attached after is has been readied. In Polymer 1.0, the
attachedcall was specially deferred until afterready. Instead, we now slightly loosen the definition ofreadyto obviate the need for deferringattached. An element hasthis.rootin ready and this dom fragment contains all of the the element's "readied" dom; however, it does not yet havethis.shadowRoot. Directly after callingreadythe content ofthis.rootis added tothis.shadowRootand thenthis.rootis set to the shadowRoot.With this change we've also added an overridable
_attachDom(dom)method which can be used to place an element's local dom in some other location than its shadowRoot.This change should maintain enough of the
attachedguarantee that Polymer 1.x had while also naturally playing better with just directly usingconnectedCallbackasPolymer.Elementusers shall do.