Fixes #3530. When updateStyles is called and an element is not atta…
#3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ched, invalidate its styling so that when it is attached, its custom properties will be updated. Also fixed a related issue with scope style cache disablement when :host function rules are used: * "property prepping" and decoration are now after static shimming so that transformed selectors are available to calculate :host function, * the detection of :host function properly accounts for type extension, * since "property prepping" was moved after shimming, apply shim was separated from this and moved before shimming so that its output can be used there.
|
LGTM! |
added 2 commits
June 22, 2016 18:39
…s is called when element is not in dom.
|
LGTM, #3708 is what broke the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3530.
…ched, invalidate its styling so that when it is attached, its custom properties will be updated.
Also fixed a related issue with scope style cache disablement when :host function rules are used: