Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for changing property to the same value #3678

Conversation

nazar-pc
Copy link
Contributor

Trivial fix, test included, no regressions detected in Chromium and Firefox.

Reference Issue

Fixes #3677

nazar-pc added a commit to nazar-pc/CleverStyle-Framework that referenced this pull request May 24, 2016
…with `Polymer.cs.behaviors.value` behavior
@kevinpschaaf
Copy link
Member

LGTM

@kevinpschaaf
Copy link
Member

As this is a more robust approach than what we had previously (to do the dirty check prior to downward binding only when there was a custom event used (e.g. {{value::input}}), we can go ahead and remove that code. I made a separate PR for that.

@nazar-pc nazar-pc deleted the fix-for-changing-property-to-the-same-value branch July 22, 2016 19:23
sorvell pushed a commit that referenced this pull request Jul 22, 2016
Remove dirty check for custom events; unnecessary after #3678. Fixes …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firing value-changed should not cause repeated value change on element itself
3 participants