Skip to content

Ensure fromAbove for downwards bindings. #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kaste
Copy link
Contributor

@kaste kaste commented Apr 16, 2016

Essentially downwards flowing data change events shouldn't echo upwards.

This is a breaking change since you actually had a test (!) that ensures the opposite.

@kaste
Copy link
Contributor Author

kaste commented Apr 16, 2016

Haha, I just saw #3077.

Note that the main problem here and #2815 was the new cached events systems, which was by far more surprising and breaking than this.

@kevinpschaaf
Copy link
Member

Going to go ahead and close this due to the breaking change issue, as noted in the code and follow-up to #3077. As you saw we tried to do this and needed to revert it due to users calling addEventListener for prop-changed events on bound elements. That said, the plan is to break this in the next major release of Polymer (which will have a lot of this code refactored).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants