Bare minimum for custom effects (take 2) #3573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes _pathEffector override completely. Replaces _notifyPathUp override.
kaste
force-pushed
the
bare-minimum-for-custom-effects2
branch
from
aa88fdb
to
f6b107d
Compare
| @@ -274,10 +274,12 @@ | |||
| var fx$ = this._propertyEffects && this._propertyEffects[model]; | |||
| if (fx$) { | |||
| for (var i=0, fx; (i<fx$.length) && (fx=fx$[i]); i++) { | |||
There was a problem hiding this comment.
Note to self: Must prestore length just like in accessors!
| @@ -224,7 +228,7 @@ | |||
| // queued events during configuration can theoretically lead to | |||
| // divergence of the passed value from the current value, but we | |||
| // really need to track down a specific case where this happens. | |||
| value = target[property]; | |||
| value = target.__data__ ? target.__data__[property] : target[property]; | |||
There was a problem hiding this comment.
I believe this reads a little clearer.
value = (target.__data__ || target)[property]
|
Closing per #3460 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #3460. Removed prestored effects in createAccessors as suggested per #3460 (comment).