Small performance tweak (primarily for start time) #3276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d styles injections (once skipping CSS mixins and variables and second time with them)
nazar-pc
added a commit
to nazar-pc/CleverStyle-Framework
that referenced
this pull request
Feb 1, 2016
List of patches applied on top of git version (1 previous patch upstreamed, 4 more added): * Polymer/polymer#2205 * Polymer/polymer#2247 * Polymer/polymer#2349 * Polymer/polymer#2419 * Polymer/polymer#3222 * Polymer/polymer#3344 * Polymer/polymer#3279 * Polymer/polymer#3276
|
@sorvell PTAL |
|
@nazar-pc do you have any perf metrics / test repo steps to back this change up? |
|
I've tested performance using my codebase with many elements on page through Dev Tools Timeline. Unfortunately it is not easy to execute that code standalone. |
sorvell
pushed a commit
that referenced
this pull request
Feb 5, 2016
|
Fixed via #3413. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small performance tweak (primarily for start time) to avoid duplicated styles injections (once skipping CSS mixins and variables and second time with them)
Besides it allows to skip some CPU cycles (observably, RegExps take a bit more time, so it worth it), it also doesn't duplicate styles in 2 stylesheets inserted at different stages, especially good for Non-Chromium browsers, since allows to emulate less in case of Shadow DOM polyfill.
I do not really care about Shady DOM, so since I've encountered 2 tests failing with this patch under Shady DOM changes only affect Shadow DOM (either native or polyfilled, both are fine).
P.S. I'm experiencing significant performance penalty with multiple CSS mixins/vars in elements that have dozens of instances on page (especially under non-Chromium, this is one of results of exploration how to optimize something in styling system without crashing everything.