importHref loads imports, async. Fixes #3113 #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we use this or make the default |
|
👍 |
| * @return {HTMLLinkElement} The link element for the URL to be loaded. | ||
| */ | ||
| importHref: function(href, onload, onerror) { | ||
| importHref: function(href, onload, onerror, optAsync) { |
There was a problem hiding this comment.
I'd say we make this default to false for back-compat.
|
LGTM with nit |
|
PTAL |
| var l = document.createElement('link'); | ||
| l.rel = 'import'; | ||
| l.href = href; | ||
|
|
||
| optAsync = typeof optAsync !== 'undefined' ? optAsync : false; |
There was a problem hiding this comment.
This can just be optAsync = Boolean(optAsync) since the default is false.
|
Last nit, then I can merge :) |
|
PTAL |
dfreedm
added a commit
that referenced
this pull request
Dec 10, 2015
importHref loads imports, async. Fixes #3113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default behavior of
importHrefto load imports async, taking them out of the rendering path. Witnessing this is a a couple of apps we're working on, not doing so causes layout flashes as the import is added to the DOM and loads.Adds an optional
asyncarg toimportHref. Defaults to true for perf and similar to xhr.R: @kevinpschaaf @sorvell @azakus