Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering causes unexpected issues #2694

Merged
merged 1 commit into from
Dec 4, 2015
Merged

Filtering causes unexpected issues #2694

merged 1 commit into from
Dec 4, 2015

Conversation

nazar-pc
Copy link
Contributor

@nazar-pc nazar-pc commented Nov 6, 2015

Introduced in 35c89f1#diff-5c83131b6cb1b0c603817554db3c5399R169, sorry about that
Fails with such example:

<style is="custom-style">
    body {
        @apply (--x-body);
    }

    body[modal-opened] {
        @apply (--x-modal-body-open);
    }
</style>

nazar-pc added a commit to nazar-pc/CleverStyle-Framework that referenced this pull request Nov 6, 2015
@nazar-pc
New git version of Polymer 1.2.1 with even more patches on top.
384f1ad 
List of patches applied on top of git version (2 previous patches upstreamed, the rest are still here + 2 new patches added):
* Polymer/polymer#2205
* Polymer/polymer#2247
* Polymer/polymer#2295
* Polymer/polymer#2349
* Polymer/polymer#2419
* Polymer/polymer#2642
* Polymer/polymer#2689
* Polymer/polymer#2692
* Polymer/polymer#2694
@nazar-pc
Copy link
Contributor Author

@azakus, please, merge this sooner than later. It fixes some edge cases issues introduced in mentioned commit.

nazar-pc added a commit to nazar-pc/CleverStyle-Framework that referenced this pull request Nov 13, 2015
@nazar-pc
New version of Polymer 1.2.2 with patches on top.
12e9331 
List of patches applied on top of git version (no new patches upstreamed since last time:():
* Polymer/polymer#2205
* Polymer/polymer#2247
* Polymer/polymer#2295
* Polymer/polymer#2349
* Polymer/polymer#2419
* Polymer/polymer#2642
* Polymer/polymer#2689
* https://github.com/Polymer/polymer/tree/fix-2692 branch supersedes Polymer/polymer#2692
* Polymer/polymer#2694
@dfreedm dfreedm added the p1 label Nov 13, 2015
@dfreedm
Copy link
Member

dfreedm commented Dec 4, 2015

LGTM

dfreedm added a commit that referenced this pull request Dec 4, 2015
@dfreedm
Merge pull request #2694 from nazar-pc/patch-1
c9ee953 
Filtering causes unexpected issues
@dfreedm dfreedm merged commit c9ee953 into Polymer:master Dec 4, 2015
@nazar-pc nazar-pc deleted the patch-1 branch December 16, 2015 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sorvell sorvell

Labels
cla: yes p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nazar-pc @dfreedm @sorvell @googlebot