Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Lint the javascript code with eslint #2600

Closed
wants to merge 1 commit into from
Closed

Conversation

fredj
Copy link
Contributor

@fredj fredj commented Oct 20, 2015

Display errors with gulp lint

work in progress

@BLamy
Copy link

BLamy commented Oct 27, 2015

Should probably be called gulp eslint as I would expect lint would be reserved for polylint once they fit that into the toolchain.

@fredj
Copy link
Contributor Author

fredj commented Oct 29, 2015

http://jscs.info/ should probably used instead as it's already the linter used in https://github.com/PolymerElements/polymer-starter-kit

@masonlouchart
Copy link

👍 for following the validation rules of the PSK. If you prefer ESLint maybe you could propose it for the PSK then add the eslint task to Polymer.

@dfreedm
Copy link
Member

dfreedm commented Feb 4, 2016

Thanks for the PR!

I'm marking this as needs investigation and/or docs to make sure we evaluate linters for the best use case.

Is the community collecting around eslint the best, or is jshint, xo, jscs, etc. the best?

@dfreedm dfreedm mentioned this pull request Feb 4, 2016
4 tasks
@dfreedm
Copy link
Member

dfreedm commented Feb 5, 2016

Alright, after reviewing other linters in #3368, I think eslint is the way to go!

I have a few tweaks I want to make on this PR, so I'm going to merge it into a different branch and close this one. I'll reference it when it's ready.

Thanks again!

@dfreedm dfreedm closed this Feb 5, 2016
dfreedm added a commit that referenced this pull request Feb 5, 2016
Modified version of #2600

- Ignores experimental and demo folders
- A few style tweaks
- Rename gulp task to `gulp lint`, and cause it to emit non-zero status
  for travis testing

Thanks to @fredj for the base PR
@dfreedm dfreedm mentioned this pull request Feb 5, 2016
@fredj fredj deleted the eslint branch June 1, 2017 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants