-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Lint the javascript code with eslint #2600
Conversation
Should probably be called |
http://jscs.info/ should probably used instead as it's already the linter used in https://github.com/PolymerElements/polymer-starter-kit |
👍 for following the validation rules of the PSK. If you prefer ESLint maybe you could propose it for the PSK then add the |
Thanks for the PR! I'm marking this as needs investigation and/or docs to make sure we evaluate linters for the best use case. Is the community collecting around eslint the best, or is jshint, xo, jscs, etc. the best? |
Alright, after reviewing other linters in #3368, I think eslint is the way to go! I have a few tweaks I want to make on this PR, so I'm going to merge it into a different branch and close this one. I'll reference it when it's ready. Thanks again! |
Display errors with
gulp lint
work in progress