Make computed properties implicitly readOnly. Fixes #1925. #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -174,7 +174,8 @@ | |||
| // ReadOnly properties have a private setter only | |||
| // TODO(kschaaf): Per current Bind factoring, we shouldn't | |||
| // be interrogating the prototype here | |||
| if (model.getPropertyInfo && model.getPropertyInfo(property).readOnly) { | |||
| var info = model.getPropertyInfo(property); | |||
There was a problem hiding this comment.
No longer guarding against model not having getPropertyInfo. We still need to do this.
| @@ -77,7 +77,7 @@ | |||
| if (args) { | |||
| var fn = this[effect.method]; | |||
| if (fn) { | |||
| this[effect.property] = fn.apply(this, args); | |||
| this._setProperty(effect.property, fn.apply(this, args)); | |||
There was a problem hiding this comment.
Cannot make a readOnly property named property. Perhaps we should change the name of _setProperty?
|
LGTM |
sorvell
pushed a commit
that referenced
this pull request
Jun 24, 2015
Make computed properties implicitly readOnly. Fixes #1925.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.