Allow user prevention of tap and track gestures from down
#1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New API: `event.detail.prevent('tap')` and `event.detail.prevent('track')`
Fixes #1823
Forward `preventDefault` from gesture events to source events
`gesture.preventDefault()` is equivalent to
`gesture.detail.sourceEvent.preventDefault()`
Remove `preventDefault()` on mousemove in track, user must use
`track.preventDefault()` to hide user selection or use `user-select:none`
Fixes #1824
Fix `preventDefault` in IE ONCE AND FOR ALL
|
@frankiefu @blasten PTAL |
| @@ -348,13 +381,12 @@ | |||
| self.info.state = self.info.started ? (e.type === 'mouseup' ? 'end' : 'track') : 'start'; | |||
| self.info.addMove({x: x, y: y}); | |||
| self.fire(t, e); | |||
| e.preventDefault(); | |||
|
lgtm, thanks for fixing it! |
|
@sorvell @kevinpschaaf PTAL |
|
LGTM |
sorvell
pushed a commit
that referenced
this pull request
Jun 17, 2015
Allow user prevention of `tap` and `track` gestures from `down`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API:
event.detail.prevent('tap')andevent.detail.prevent('track')Fixes #1823
Forward
preventDefaultfrom gesture events to source eventsgesture.preventDefault()is equivalent togesture.detail.sourceEvent.preventDefault()Remove
preventDefault()on mousemove in track, user must usetrack.preventDefault()to hide user selection or useuser-select:noneFixes #1824
Fixes PolymerElements/paper-drawer-panel#50