Move non-webcomponents script unresolved case to load instead of synchronous
#1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,7 @@ | |||
| if (window.WebComponents) { | |||
| addEventListener('WebComponentsReady', resolve); | |||
| } else { | |||
| resolve(); | |||
| addEventListener('load', resolve); | |||
There was a problem hiding this comment.
Let's use document.readyState iff not at least at interactive and then resolve on interactive. load is overly long.
dfreedm
force-pushed
the
fix-scripts-head-unresolved
branch
from
a8c6347
to
2258920
Compare
|
@sorvell PTAL with the new patch |
|
LGTM, thx. |
sorvell
pushed a commit
that referenced
this pull request
Jun 4, 2015
Move non-webcomponents script unresolved case to `load` instead of synchronous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1723