Fix for IE. #1717
Merged
Fix for IE. #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure rule.propertyInfo is correctly set in style-properties.html. It was checking a wrong attribute: rule.properties instead of rule.propertyInfo before calling decorateRule(). * Fix a condition check in custom-style.html when propertyInfo is null or undefined.
|
@sorvell PTAL |
|
LGTM... thx! |
|
Thanks! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My website was not working on IE because the styles were missing -- and the IE javascript console said that it could not read "cssText" property. I dig down a little bit and found that this simple two-line patch makes it working perfectly on IE 11 as well as Chrome and Firefox. I haven't tested this on other versions of IE.
rule.propertyInfois correctly set in style-properties.html. It was checking a wrong attribute:rule.propertiesinstead ofrule.propertyInfobefore callingdecorateRule().rule.propertyInfois null or undefined.