Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xstyle 1555 #1602

Merged
merged 4 commits into from
May 25, 2015
Merged

Xstyle 1555 #1602

merged 4 commits into from
May 25, 2015

Conversation

sorvell
Copy link
Contributor

@sorvell sorvell commented May 23, 2015

Fixes #1555
Fixes #1543

Steven Orvell added 2 commits May 23, 2015 08:30
Fixes #1555 by making :host properties apply before outer scope prope…
380fc42 
…rties so scope properties override them; also adds '*' as an own scope matcher. Own scope properties are applied last; this gives the element the final say and allows property retargeting.
Fixes #1543
be2c8e6
@kevinpschaaf
Copy link
Member

LGTM

kevinpschaaf added a commit that referenced this pull request May 25, 2015
@kevinpschaaf
Merge pull request #1602 from Polymer/xstyle-1555
ec3ad32 
Xstyle 1555
@kevinpschaaf kevinpschaaf merged commit ec3ad32 into master May 25, 2015
@kevinpschaaf kevinpschaaf deleted the xstyle-1555 branch May 25, 2015 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom properties defined on :host shouldn't override document styles. Default values for custom variables
3 participants
@sorvell @kevinpschaaf @googlebot