Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iterate behavior mixins in reverse order as the hasOwnProperty chec… #1588

Merged
merged 3 commits into from
May 22, 2015

Conversation

sjmiles
Copy link
Contributor

@sjmiles sjmiles commented May 21, 2015

…k means whoever goes first wins

@sjmiles
Copy link
Contributor Author

sjmiles commented May 21, 2015

@cdata

@sjmiles
Copy link
Contributor Author

sjmiles commented May 22, 2015

This PR is faulty, don't merge until I can fix it.

- iterate `behaviors` in natural order for prepping
- aggregate hostAttributes at prep-time for proper override behavior
- fix/add tests
- remove vestigial mixins.html file
@sjmiles
Copy link
Contributor Author

sjmiles commented May 22, 2015

Rebuilt this PR to actually do what it claims. Also added repairs for hostAttributes overriding and better tests. Note the test throws a warning in the console on purpose.

Should be ready for real now. Please review.

kevinpschaaf added a commit that referenced this pull request May 22, 2015
iterate behavior mixins in reverse order as the `hasOwnProperty` chec…
@kevinpschaaf kevinpschaaf merged commit 8578a27 into master May 22, 2015
@kevinpschaaf kevinpschaaf deleted the fix-inter-behavior-overrides branch May 22, 2015 22:27
@kevinpschaaf
Copy link
Member

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants