0.8 gestures in core #1486
Merged
0.8 gestures in core #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow behaviors to easily override event listener creation Expose a Behavior Use a coarse mouse on/off feature for handling synthetic mouse events and ghost clicks Implement all in the burndown list Add a smoke test only handle one finger with touchevents Make sure track state can be "start" for mouse Minor fix for touchevent single-finger check bolt basic gestures onto core add tests for gesture private data tracking
dfreedm
force-pushed
the
0.8-gestures-in-core
branch
from
842b99a
to
c8cde9b
Compare
| // but this breaks `<input>` focus and link clicks | ||
| // disable mouse handlers for MOUSE_TIMEOUT ms after | ||
| // a touchend to ignore synthetic mouse events | ||
| var MOUSE_CANCELLER = function(mouseEvent) { |
There was a problem hiding this comment.
suggest camelCasing function names
|
LGTM (refinements to follow) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dfreedman's latest gesture code tweaked to work in core