You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the fire function, in file utils.js at line 153:
vardetail=detail||{};
This restricts 0 or empty Strings from going through the fire function, when they are perfectly fine objects. So, fire should only check the detail variable for undefined or null, things that would cause a nasty error on the other side.
The text was updated successfully, but these errors were encountered:
Normally, it would be good practice to have a test as well, but I'm making an exception because this is part of a larger issue.
Namely, this.fire has evolved two responsibilities (event sugaring and dom-based RPC), and I believe this method needs to be factored or at least revisited (in particular, why is detail not allowed to be null? the reason may be vestigial).
I'm going to leave this ticket open until I can link it to a more specific ticket for the larger question.
In the fire function, in file utils.js at line 153:
This restricts 0 or empty Strings from going through the fire function, when they are perfectly fine objects. So, fire should only check the detail variable for undefined or null, things that would cause a nasty error on the other side.
The text was updated successfully, but these errors were encountered: