Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core-scroll-header-panel background missing? #576

Closed
royjr opened this issue Jun 29, 2014 · 2 comments
Closed

core-scroll-header-panel background missing? #576

royjr opened this issue Jun 29, 2014 · 2 comments

Comments

@royjr
Copy link

royjr commented Jun 29, 2014

In the core-scroll-header-panel demo, the header background (bg9.jpg) and color (yellow) does not load. Upon randomly scrolling up and down, the header image/color appears at times. (hard to reproduce)

nobg

Any ideas?
robdodson added a commit to robdodson/core-scroll-header-panel that referenced this issue Jun 29, 2014
@robdodson
Force core-toolbar/core-header to be transparent
bac43c4 
Because core-toolbar now has a default background (aa8b336327958382adcae3dcfc43a9cf27292ebc) it breaks `core-scroll-header-panel` because the background color was previously transparent (Polymer/polymer#576). This change forces the content inside of `#headerContent` (either `core-toolbar` or `.core-header`) to be transparent.
@robdodson robdodson mentioned this issue Jun 29, 2014
Closed
@robdodson
Copy link
Contributor

That looks like it was caused by this change: googlearchive/core-toolbar@aa8b336

We gave core-toolbar a default background color (before it was transparent) so that is blocking out the background image. The quick fix is to set the CSS for core-toolbar to background: transparent on line 55.

This PR should hopefully fix the issue (googlearchive/core-scroll-header-panel#7)

@royjr
Copy link
Author

royjr commented Jun 29, 2014

Perfect fix for now =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Force core-toolbar/core-header to be transparent robdodson/core-scroll-header-panel
3 participants
@robdodson @royjr and others