Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example jsbin has style outside template #5140

Closed
LarsDenBakker opened this issue Mar 4, 2018 · 2 comments
Closed

Example jsbin has style outside template #5140

LarsDenBakker opened this issue Mar 4, 2018 · 2 comments
Assignees

Comments

@LarsDenBakker
Copy link
Contributor

The issue template links to https://jsbin.com/luhaxab/1/edit?html,css,js,output

Which has:

    <style>
      :host {
        display: block;
      }
    </style>
    
    <template>
      <div>[[prop]]</div>
    </template>

That should be:

    <template>
      <style>
        :host {
          display: block;
        }
      </style>
      <div>[[prop]]</div>
    </template>
@TimvdLippe
Copy link
Contributor

The first edit did have this issue, but the latest version (http://jsbin.com/luhaxab/edit?html,output) which is also linked in the CONTRIBUTING.md, has the style elements inside the template.

Westbrook added a commit to Westbrook/polymer that referenced this issue Mar 7, 2018
Fixes Polymer#5140

This version of the URL matched CONTRIBUTING.md
@LarsDenBakker
Copy link
Contributor Author

Its in the issue template. There is a PR for it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants