Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:dir generates incorrect selectors when an element uses CSS Custom Properties #4925

Closed
6 tasks done
dfreedm opened this issue Nov 7, 2017 · 1 comment
Closed
6 tasks done

:dir generates incorrect selectors when an element uses CSS Custom Properties #4925

dfreedm opened this issue Nov 7, 2017 · 1 comment
Assignees
@dfreedm
Labels
1.x css p1

Comments

@dfreedm
Copy link
Member

dfreedm commented Nov 7, 2017

Description

When the CSS Custom Property shim activates for an element, the :dir() selector will be prefixed with an instance selector that breaks the :dir() transform

Live Demo

http://jsbin.com/yabomib/edit?html,output

Steps to Reproduce

Expected Results

hi should be orange

Actual Results

hi is black

Browsers Affected

  • Chrome
  • Firefox
  • Edge
  • Safari 9
  • Safari 8
  • IE 11

Versions

  • Polymer: v1.11.0
@dfreedm dfreedm self-assigned this Nov 7, 2017
@dfreedm dfreedm mentioned this issue Nov 7, 2017
Merged
dfreedm added a commit that referenced this issue Nov 7, 2017
@dfreedm
Fix :dir selector when element uses CSS Custom Property Shim
8fd3e93 
Fixes #4925
@dfreedm dfreedm mentioned this issue Nov 7, 2017
Merged
@TimvdLippe
Copy link
Contributor

Should be fixed per #4926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreedm dfreedm

Labels
1.x css p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfreedm @TimvdLippe