Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a disable-upgrade option for Polymer 2 #4909

Closed
sorvell opened this issue Oct 31, 2017 · 1 comment
Closed

Provide a disable-upgrade option for Polymer 2 #4909

sorvell opened this issue Oct 31, 2017 · 1 comment
Assignees
@sorvell
Labels
2.x p1 source: hooli

Comments

@sorvell
Copy link
Contributor

sorvell commented Oct 31, 2017

In Polymer 1.x users could add a disable-upgrade attribute to elements to defer upgrade work until the attribute was removed. This feature is not possible in Polymer 2 due to removal of bespoke API (e.g. users implement connectedCallback rather than attached); however, we should be able to add a mixin that users can opt-in to using.
@sorvell sorvell self-assigned this Oct 31, 2017
sorvell pushed a commit that referenced this issue Dec 15, 2017
Adds Polymer.DisableUpgradeMixin
62ce314 
Fixes #4909. Elements using this mixin will not "enable" themselves when they have a `disable-upgrade` attribute. This mirrors a feature of Polymer 1.x but is now opt-in.
@sorvell sorvell mentioned this issue Dec 15, 2017
Merged
@kevinpschaaf
Copy link
Member

Current status: PR #4994 is up which adds an optional mixin for deferring all connectedCallback work. Per IRL review, last step is to add Legacy support for deferring user created callback work (not possible with non-Legacy constructor work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
2.x p1 source: hooli
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sorvell @kevinpschaaf