Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS native label -> checkbox tap doesn't always toggle check status #4717

Closed
1 task done
sacah opened this issue Jul 3, 2017 · 3 comments
Closed
1 task done

iOS native label -> checkbox tap doesn't always toggle check status #4717

sacah opened this issue Jul 3, 2017 · 3 comments
Assignees

Comments

@sacah
Copy link

sacah commented Jul 3, 2017

Description

Having a LABEL linked with an INPUT CHECKBOX via native FOR attribute, including Polymer 1.9.1/1.9.2, tapping on label doesn't always toggle checkboxes status.

Live Demo

https://jsfiddle.net/t2wr2cob/

Steps to Reproduce

Visit the above on an iOS device, I tested on iPad 10.3, iPhone 10.3
Tap on the 'Native checkbox' label a few times, it often works the first few times, then you'll see the label highlight as it received the tap, but the checkbox doesn't toggle.
Occasionally it worked every time, I re-ran the fiddle and it would break again.

If you disable polymer 1.9.2 from being loaded, but leave webcomponents-lite loading, problem doesn't exist. It's only when you include polymer.html#v1.9.2 that it breaks.

Expected Results

Checkbox toggles on tap

Actual Results

Checkbox often does not toggle on tap

Browsers Affected

  • Mobile Safari 10

Versions

  • Polymer: v1.9.2
  • webcomponents: v1.9.2
@straker
Copy link

straker commented Sep 15, 2017

Any progress on this? I tested this with iOS 11 as well as polymer 2, still broken

@sorvell sorvell added the 2.x label Dec 21, 2017
@marybeshaw
Copy link

This is still a problem in Polymer 2. Any progress?

@dfreedm
Copy link
Member

dfreedm commented Jan 12, 2018

Yep, this is a bug in the ghost click prevention code not understanding label clicks. Should be easy enough to fix by keeping track of label clicks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants